Skip to content

build(deps): keep nodes running and get test results sooner - #1447

Merged
MicBun merged 1 commit into
mainfrom
bump-kwil-db-keep-nodes-running
Oct 13, 2026
Merged

MicBun merged 1 commit into
mainfrom
bump-kwil-db-keep-nodes-running

Conversation

@MicBun

@MicBun MicBun commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

The node pins kwil-db at 6608a4cc. This moves the pin to 284bfd01, the head of kwil-db main, which adds the four pull requests merged there since:

The slow integration tests run every test on that harness. A test database that stalls now costs its test a minute, where it held its job for two hours and then made the job's retry rerun all of its packages. Applying the node's migrations and seed data to a test database took about 22 seconds and now takes about 5, because most of that time went to the reload.

Before the release

  • Executing a block gives the same results as before. The new reload query returns the same tables as the old one, which the first pull request above checked with reflect.DeepEqual on every namespace of a database holding the node's migrations. The second pull request changes only how a node admits transactions.
  • The third changes what a restore produces only when it restores into a database kwild has already opened, which happens only with resync_when_behind above 0. The restored tables then get the replica identities a new node gets from the same snapshot, so the node hashes deletes and updates as the network does.
  • The fourth changes only what a node does after a block fails to execute. A fatal database error still stops the node at once. A block applied again can still run to another app hash, when the failed attempt left something in the memory of the interpreter or an extension, such as a table the block created. The node then stops, and its log says that a restart replays the block.
  • The four add no config key, migration or p2p protocol.
  • kwil-db/core changes only in core/types: the new ErrMalformedTx and its mapping to and from code 1. The node's own code calls neither mapping function.

Related Problem

How Has This Been Tested?

  • go build ./... and go vet -tags kwiltest ./... are clean with Go 1.25.3, the version CI and the Dockerfile use.

  • The go.mod diff is the two kwil-db lines, and go mod tidy changed nothing else.

  • The 42 packages that CI tests on a pull request, 25 of them with tests, pass locally with the same go test -failfast -p 1 -count=1 -tags=kwiltest command.

  • On one node built from this branch, user.broadcast with an empty transaction got code 1, malformed transaction: no body. user.broadcast without a transaction and user.estimate_price without a body got invalid params. The node went on producing blocks.

  • The slow integration tests do not run on a pull request that changes only go.mod, so I started them on this branch by hand. All three jobs passed on their first attempt. order_book took 23m15s, streams 16m22s and rest 25m31s, and the whole run 25m36s. On the previous pin the same jobs took 41m28s, 42m46s and 50m25s, and the whole run 50m29s, in the run linked from the pull request that split them into three jobs. Twice in this run a test database did not report ready within a minute, in TestRequestAttestationFees and in TestQueries. The harness replaced it each time, and both tests passed.

@holdex

holdex Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Time Submission Status

Member # Time Running Total Status Last Update
MicBun 2h ✅ Submitted Oct 13, 2026, 6:26 AM

Submit or update total time with:

@holdex pr submit-time 2h

Add time on top of previous submission with:

@holdex pr add-time 1h30m

See available commands to help comply with our Guidelines.

@MicBun MicBun self-assigned this Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a5e3a1fa-111b-4cf4-bd88-625ecd415904
📥 Commits

Reviewing files that changed from the base of the PR and between c14b49b and 31306ee.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The module updates the pseudo-versions of both Kwil DB dependencies. Their module paths remain unchanged.

Changes: Kwil DB dependencies

Layer / File(s) Summary
Update Kwil DB versions
go.mod
Both Kwil DB dependencies use newer pseudo-versions dated 2026-10-12 instead of 2026-10-07.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 31306

No actionable merge-blocking issue is established. Confirm the slow integration suite’s result before claiming the one-hour objective has been met.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check Warning Issue #1445 requires the slow integration tests on a node pull request to finish within one hour and stalled runs to fail within minutes. This PR updates only the two kwil-db dependency declarations… Add the required node CI workflow changes, or provide reviewable evidence that the current workflow now runs the slow integration tests for the relevant pull requests and enforces the one-hour and stalled-run limits. Re-run the affected wor…
Passed Passed checks (4 passed)
Check name Status Explanation
Out of Scope Changes check Passed The reviewed change is limited to the kwil-db and kwil-db/core version updates. The described upstream changes address the slow integration-test setup and execution behavior identified by issue #1…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the dependency update’s intended effects: improved node reliability and faster test results. It is relevant to the primary change.
Full details: Linked Issues check

Explanation

Issue #1445 requires the slow integration tests on a node pull request to finish within one hour and stalled runs to fail within minutes. This PR updates only the two kwil-db dependency declarations. The PR description states that pull requests changing only go.mod do not run the slow integration tests, and it reports only manually started runs. No node CI workflow change is present to make the issue outcome apply to relevant pull requests. The imported kwil-db changes address test-database stalls, but the complete linked-issue coding requirement is not established by this PR.

Resolution

Add the required node CI workflow changes, or provide reviewable evidence that the current workflow now runs the slow integration tests for the relevant pull requests and enforces the one-hour and stalled-run limits. Re-run the affected workflow and record the result.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MicBun

MicBun commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

@holdex pr submit-time 2h

@MicBun
MicBun merged commit 3336eed into main Oct 13, 2026
17 checks passed
@MicBun
MicBun deleted the bump-kwil-db-keep-nodes-running branch October 13, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: developers can't get node PR checks back within an hour

1 participant